{"id":452,"date":"2013-02-26T22:19:20","date_gmt":"2013-02-27T03:19:20","guid":{"rendered":"http:\/\/blogs.law.harvard.edu\/acts\/?p=452"},"modified":"2013-02-26T22:20:43","modified_gmt":"2013-02-27T03:20:43","slug":"feature-branches-with-code-reviews","status":"publish","type":"post","link":"https:\/\/archive.blogs.harvard.edu\/acts\/2013\/02\/26\/feature-branches-with-code-reviews\/","title":{"rendered":"Feature Branches with Code Reviews"},"content":{"rendered":"<p>We have been trying to find a process for doing code reviews for a little while. Because most of our current projects are in github, it made sense to try and use some of the github features to help in this process.<\/p>\n<p>I have been using issues for stories and milestones for sprints for a while. And it works out nicely because I get a pretty neat <a href=\"http:\/\/blogs.law.harvard.edu\/acts\/2012\/11\/10\/gamification-in-software-development\/\" title=\"Gamification in Software Development\">gamificationy results<\/a>. <\/p>\n<p>So I started using a feature branch in order to have the ability to make pull requests on my own project and get a discussion thread before code is merged into the trunk (production). <\/p>\n<p>https:\/\/github.com\/Harvard-ATG\/Quizmo\/pull\/119<\/p>\n<p>This discussion is a great way to get a reasonable code review before merging code. Right now we&#8217;ve decided to only do this for non-trivial changes, but with a very high bar on &#8220;trivial&#8221;.<\/p>\n","protected":false},"excerpt":{"rendered":"<p>We have been trying to find a process for doing code reviews for a little while. Because most of our current projects are in github, it made sense to try and use some of the github features to help in this process. I have been using issues for stories and milestones for sprints for a [&hellip;]<\/p>\n","protected":false},"author":4571,"featured_media":0,"comment_status":"open","ping_status":"open","sticky":false,"template":"","format":"standard","meta":{"footnotes":""},"categories":[63924,910],"tags":[63996,64046,64047,64000,64048],"class_list":["post-452","post","type-post","status-publish","format-standard","hentry","category-atg","category-development","tag-agile","tag-branch","tag-code-review","tag-github","tag-pull-request"],"jetpack_featured_media_url":"","_links":{"self":[{"href":"https:\/\/archive.blogs.harvard.edu\/acts\/wp-json\/wp\/v2\/posts\/452","targetHints":{"allow":["GET"]}}],"collection":[{"href":"https:\/\/archive.blogs.harvard.edu\/acts\/wp-json\/wp\/v2\/posts"}],"about":[{"href":"https:\/\/archive.blogs.harvard.edu\/acts\/wp-json\/wp\/v2\/types\/post"}],"author":[{"embeddable":true,"href":"https:\/\/archive.blogs.harvard.edu\/acts\/wp-json\/wp\/v2\/users\/4571"}],"replies":[{"embeddable":true,"href":"https:\/\/archive.blogs.harvard.edu\/acts\/wp-json\/wp\/v2\/comments?post=452"}],"version-history":[{"count":2,"href":"https:\/\/archive.blogs.harvard.edu\/acts\/wp-json\/wp\/v2\/posts\/452\/revisions"}],"predecessor-version":[{"id":454,"href":"https:\/\/archive.blogs.harvard.edu\/acts\/wp-json\/wp\/v2\/posts\/452\/revisions\/454"}],"wp:attachment":[{"href":"https:\/\/archive.blogs.harvard.edu\/acts\/wp-json\/wp\/v2\/media?parent=452"}],"wp:term":[{"taxonomy":"category","embeddable":true,"href":"https:\/\/archive.blogs.harvard.edu\/acts\/wp-json\/wp\/v2\/categories?post=452"},{"taxonomy":"post_tag","embeddable":true,"href":"https:\/\/archive.blogs.harvard.edu\/acts\/wp-json\/wp\/v2\/tags?post=452"}],"curies":[{"name":"wp","href":"https:\/\/api.w.org\/{rel}","templated":true}]}}